Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cte support #413

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Cte support #413

merged 7 commits into from
Nov 8, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Nov 1, 2024 •
edited
Loading

Support query:

          with t1 as (
               select * from int1.tbl1
            )
            select t1.id, t2.* from t1 
            join int2.tbl2 t2 on t1.id>t2.id

fix: mindsdb/mindsdb#4291

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sql
   __about__.py10100%1–10
   __init__.py1292382%43, 47, 93, 110, 113, 134–153, 160–161, 178
mindsdb_sql/parser
   lexer.py165199%243
   logger.py19479%14, 17, 23, 26
   parser.py4603193%48, 53, 73, 77, 81, 87, 91–93, 121–128, 182, 199, 249, 253, 317, 346–347, 367, 378, 491, 526, 557, 567, 581, 662
   utils.py46491%73–79
mindsdb_sql/parser/ast
   base.py36781%13, 28, 31, 49–52
   create.py761087%7–8, 23, 28, 91–96
   drop.py52296%10, 13
   insert.py63494%39–41, 46
   show.py48198%18
   update.py53591%40–42, 75–76
mindsdb_sql/parser/ast/select
   case.py32294%19, 22
   constant.py36197%23
   data.py11282%15, 19
   identifier.py64789%43, 80–85
   native_query.py13192%25
   operation.py131497%56, 65, 168, 187
   parameter.py11191%10
   select.py97397%148–153
   star.py12283%8–9
   union.py23196%18
mindsdb_sql/parser/dialects/mindsdb
   knowledge_base.py46198%79
   lexer.py2622192%343, 345, 347, 359, 361, 363, 369–387
   parser.py10272697%118, 122, 261, 286, 383, 569, 586, 610–611, 807, 861, 938, 1065, 1075, 1113–1114, 1143, 1154, 1236, 1299, 1360, 1844, 1852, 1905–1908
mindsdb_sql/parser/dialects/mysql
   lexer.py23674%16, 18, 20, 32, 34, 36
   parser.py6132496%131, 133, 226–227, 326, 356, 373, 423, 427, 501, 511, 549–550, 570, 581, 702, 730, 735–737, 741, 758, 907, 1051
   show_index.py171135%10–12, 15–23, 26–27
mindsdb_sql/planner
   plan_join.py3731795%145, 153, 187, 196, 223, 227, 316, 366, 386, 398–399, 449, 477, 483, 500, 523, 525
   plan_join_ts.py1791094%53, 60, 83–84, 129, 181, 185, 193, 268, 335
   query_plan.py22864%13–21, 30
   query_planner.py4266784%41–42, 65–66, 75, 174, 317, 335–337, 344, 445, 473–551, 594–595, 608, 634, 708, 738, 764, 789–791
   query_prepare.py2866179%76, 78, 86–116, 227, 249, 272, 315, 336, 362, 391–445, 448–454, 485, 498–500, 509, 528
   step_result.py14286%7, 12
   steps.py1581690%12, 17, 25, 30–32, 51–53, 61–64, 90–92
   ts_utils.py67691%59, 61, 83–86, 90
   utils.py2422789%60, 106, 112, 127, 139, 151, 154, 166, 194, 207, 222, 228, 233, 240, 242, 247, 260, 265, 271, 277, 291, 308, 338–339, 350–351, 366
mindsdb_sql/render
   sqlalchemy_render.py4627085%56, 91, 93, 105, 110, 127, 129, 131, 133, 195, 212–213, 224–225, 243, 273, 275, 286, 323, 337, 343, 394, 459–463, 474–478, 508, 523, 537, 542, 555–556, 559–560, 567, 590–601, 621, 654–678, 701, 707, 747–750, 771–774
TOTAL666249993% 

Tests Skipped Failures Errors Time
685 1 💤 0 ❌ 0 🔥 25.159s ⏱️

@ea-rus ea-rus marked this pull request as ready for review November 2, 2024 17:19
@ea-rus ea-rus merged commit 57ba416 into staging Nov 8, 2024
7 checks passed
@ea-rus ea-rus mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Tracking PRs
Status: merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: complex queries support
1 participant
@ea-rus